Re: [PATCH v5 3/6] pack-bitmap-write: learn pack.writeBitmapLookupTable and add tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 10, 2022 at 11:09:40AM +0200, Johannes Schindelin wrote:
> Hi Abhradeep,
>
> On Tue, 9 Aug 2022, Abhradeep Chakraborty wrote:
>
> >  I noticed in the 'setup partial bitmaps' test case that if we comment
> > out the line `git repack &&` , it runs successfully.
> >
> >     test_expect_success 'setup partial bitmaps' '
> >         test_commit packed &&
> >         # git repack &&
> >         test_commit loose &&
> >         git multi-pack-index write --bitmap 2>err &&
> >         ...
> >     '
>
> That's interesting. Are the `.bitmap` and `.midx` files updated as part of
> that `repack`?

They aren't. You can cause a MIDX / bitmap to be updated during `git
repack` provided that the flags `--write-midx` and
`--write-bitmap-index` are given to `repack`.

But the point of that `git repack` in this test case specifically is to
ensure that the commit generated on the previous line is included in a
new pack, and that that pack makes its way into the MIDX.

So removing that invocation of `git repack` means that the set of packs
would be unchanged, and the `git multi-pack-index write --bitmap` would
be a noop. That should rule out the theory that the existing MIDX is
broken, since without the `git repack`, we'd be using that MIDX in
subsequent tests (which pass).

Thanks,
Taylor



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux