Hi Matheus,
On Sun, 14 Aug 2022, Matheus Tavares wrote:
> Main changes since v3:
> Patch 2:
> - Mentioned in commit message why we removed the flush() calls for the
> log file handler.
> - Removed 'buf[size] = \0' and relied on the fact that packet_read()
> already 0-terminates the buffer. This also allows us to use NULL
> instead of &size in many places, dropping down the unneeded variable.
> - Used parse-options instead of manual argv fiddling. I'm not strongly
> about one way or another, but I found the parse-options slightly
> easier for new options that may be added in the future.
> - Style: removed unnecessary {} and newline.
While I think that the `parse-options` were unnecessary churn, I won't
object because I find that I cannot motivate myself to care all that much
(other reviewers seem to find this type of aspects super exciting, a
sentiment I do not share). I care much more about the essence, about the
actual improvement brought about by your patch series, which is to reduce
Git's test suite's reliance on scripting.
The range-diff looks good to me, and I think this iteration is good to go.
Thanks,
Dscho
