add, diff, resolved, and status didn't use the crt_series that was initialized for them. So don't initialize it, since that means (1) less work and (2) they won't fail when HEAD is detached. Note that this doesn't completely fix the problem with detached HEAD: a number of other commands (e.g. branch) don't always need to refer to a current series, but currently fails on a detached HEAD even in those situations. Signed-off-by: Karl Hasselström <kha@xxxxxxxxxxx> --- stgit/commands/add.py | 2 +- stgit/commands/diff.py | 2 +- stgit/commands/resolved.py | 2 +- stgit/commands/status.py | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/stgit/commands/add.py b/stgit/commands/add.py index 264ab9f..ceea188 100644 --- a/stgit/commands/add.py +++ b/stgit/commands/add.py @@ -31,7 +31,7 @@ Add the files or directories passed as arguments to the repository. When a directory name is given, all the files and subdirectories are recursively added.""" -directory = DirectoryHasRepository() +directory = DirectoryHasRepository(needs_current_series = False) options = [] diff --git a/stgit/commands/diff.py b/stgit/commands/diff.py index 42e8367..9ffbb4a 100644 --- a/stgit/commands/diff.py +++ b/stgit/commands/diff.py @@ -42,7 +42,7 @@ rev = '([patch][//[bottom | top]]) | <tree-ish> | base' If neither bottom nor top are given but a '//' is present, the command shows the specified patch (defaulting to the current one).""" -directory = DirectoryHasRepository() +directory = DirectoryHasRepository(needs_current_series = False) options = [make_option('-r', '--range', metavar = 'rev1[..[rev2]]', dest = 'revs', help = 'show the diff between revisions'), diff --git a/stgit/commands/resolved.py b/stgit/commands/resolved.py index c2ef678..8b2aba2 100644 --- a/stgit/commands/resolved.py +++ b/stgit/commands/resolved.py @@ -34,7 +34,7 @@ Mark a merge conflict as resolved. The conflicts can be seen with the 'C'. This command also removes any <file>.{ancestor,current,patched} files.""" -directory = DirectoryHasRepository() +directory = DirectoryHasRepository(needs_current_series = False) options = [make_option('-a', '--all', help = 'mark all conflicts as solved', action = 'store_true'), diff --git a/stgit/commands/status.py b/stgit/commands/status.py index a688f7e..360fabf 100644 --- a/stgit/commands/status.py +++ b/stgit/commands/status.py @@ -40,7 +40,7 @@ under revision control. The files are prefixed as follows: A 'refresh' command clears the status of the modified, new and deleted files.""" -directory = DirectoryHasRepository() +directory = DirectoryHasRepository(needs_current_series = False) options = [make_option('-m', '--modified', help = 'show modified files only', action = 'store_true'), - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html