On Wed, Aug 10, 2022 at 04:04:17PM -0400, Jeff King wrote: > > Maybe downgrade to info or ignore by default then? It might still be > > an issue for people who wilfully upgraded the diagnostic to error > > hoping to catch the, but hopefully if they did that they'd rather get > > the notice later than never? > > Yeah, that may be a sensible resolution. All things being equal I think > "warning" is the right level, but out of caution and the historical > precedent, maybe downgrading it to "info" is justified. > > It should be easy to work that into the patch I showed earlier. OK, so here are cleaned-up patches to do that. [1/3]: tree-walk: add a mechanism for getting non-canonicalized modes [2/3]: fsck: actually detect bad file modes in trees [3/3]: fsck: downgrade tree badFilemode to "info" fsck.c | 4 ++-- fsck.h | 2 +- packfile.c | 2 +- t/t1450-fsck.sh | 14 ++++++++++++++ t/t5504-fetch-receive-strict.sh | 17 +++++++++++++++++ tree-walk.c | 14 +++++++++----- tree-walk.h | 8 +++++++- 7 files changed, 51 insertions(+), 10 deletions(-) -Peff
