Hi Junio, On Fri, 15 Jul 2022, Johannes Schindelin wrote: > On Thu, 14 Jul 2022, Junio C Hamano wrote: > > > Junio C Hamano <gitster@xxxxxxxxx> writes: > > > > > ... I am not sure about this part. Do we have any other codepath to > > > show "to debug, run the program with this" suggestion? Adding it in > > > the documentation is probably good, but this is an extra message > > > that is much larger than the "owned by X but you are Y" message that > > > would be shown. With or without the environment set, the output > > > will become noisier with this patch. I wonder if we are better off > > > giving the information that is given in the warning (in compat/ part > > > of the patch) _unconditionally_ in the message, which would make it > > > less noisy overall. > > > > I am wondering if passing a struct to allow is_path_owned_by*() > > helper(s) to report the detail of the failures they discover a > > cleaner way to do this. To illustrate what I meant, along the > > lines of the following patch, with any additional code to actually > > stuff messages in the strbuf report, in the is_path_owned_by*() > > implementation. > > I like it! Let me play with this, after this coming week (during which I > plan to be mostly offline). I had to play with it for a while until I could make it work, but eventually I managed to do it. The second iteration was just sent, and implements this route. Thank you, Dscho
