On Wed, Aug 03 2022, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > >> Refactor the juggling of "rev.pending" and our replacement for it >> amended in the preceding commit so that: >> ... >> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> >> Helped-by: Jeff King <peff@xxxxxxxx> > > List trailer lines chronologically, please. Willdo. > I may have said this earlier, but once we start using the "prepare a > blank one, copy it to clear another" pattern, we should stop using > memcpy() and use structure assignment, especially if we are trying to > make our intent clear. Yeah, I saw that. I took it as we should consider changing this more generally (e.g. with coccicheck etc.). This was mentioned in one of the original threads about the memcpy() idiom, but IIRC there was some reason to think that it wasn't as widely supported, or in any case we'd want to re-rest that the compilers we care about similarly optimize it. So I think it's best to just use the more widely used pattern for now, and if we'd like change them all in some follow-up change...
