On Tue, Aug 02, 2022 at 05:33:10PM +0200, Ævar Arnfjörð Bjarmason wrote: > Changes since v2: > > * I think the rewrite here of fixing the leak should address Jeff > King's concerns. I was somewhat mentally stuck on trying to change > the code to make the leak fix easier, and then having the leak fix. > > But I think as the new 3/6 shows fixing the leak first is much > easier, and more straightforward to explain. Yeah, I think fixing the leak first is fine. I did prefer the end result of the earlier round, but I can live with it either way. > * A new 4/6 then follows-up and rewrites the variable clobbering that > was needed for the pre-image of 3/6. > > * Don't reference the "XXX" comment in 6/6. I'd hoped you'd take my replacement 5/6, but again, I can live with it either way. -Peff
