On 7/27/2022 7:00 PM, Ævar Arnfjörð Bjarmason wrote: > > On Mon, Jul 25 2022, Derrick Stolee via GitGitGadget wrote: > >> From: Derrick Stolee <derrickstolee@xxxxxxxxxx> >> [...] > > Add a: > > TEST_PASSES_SANITIZE_LEAK=true I trust this is important for your series that flags tests that _could_ pass with this. Thanks. >> +. ./test-lib.sh >> + >> +. "$TEST_DIRECTORY"/lib-httpd.sh >> +start_httpd >> + >> +test_expect_success 'get by URL: 404' ' >> + url="$HTTPD_URL/none.txt" && >> + cat >input <<-EOF && >> + capabilities >> + get $url file1 >> + EOF >> + >> + test_must_fail git remote-http $url <input 2>err && >> + test_path_is_missing file1 && >> + grep "failed to download file at URL" err && >> + rm file1.temp > > This should presumably be a : > > test_when_finished "rm file.temp" Yes. Thanks. >> +' >> + >> +test_expect_success 'get by URL: 200' ' >> + echo data >"$HTTPD_DOCUMENT_ROOT_PATH/exists.txt" && >> + >> + url="$HTTPD_URL/exists.txt" && >> + cat >input <<-EOF && >> + capabilities >> + get $url file2 >> + >> + EOF >> + >> + GIT_TRACE2_PERF=1 git remote-http $url <input && > > Is this ad-hoc debugging that snuck into the test? Nothing here needs > this GIT_TRACE2_PERF... Good eye. Removed. Thanks, -Stolee
