On Thu, Jul 28, 2022 at 5:09 PM Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: > On Thu, Jul 28, 2022 at 4:59 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > >> - [--range-diff=<previous> [--creation-factor=<percent>]] > > >> + [--range-diff=<previous> [--creation-factor=<factor>]] > > > > Eric, I am not sure if the other patch for the range-diff command as > > a standalone patch is worth it. Perhaps you can help me by > > submitting a single combined patch to cover the above as well as > > what we wrote in the two patches, with you marked as the primary > > author and with Helped-by: that credits Ævar? > > Will do. Given Dscho's response in [1] which states that "percent" is more accurate than "factor", perhaps these two patches are unwanted after all, and instead the documentation of "creation factor" in Documentation/git-range-diff.txt ought to be expanded with a better explanation, as hinted in [2]. [1]: https://lore.kernel.org/git/85snn12q-po05-osqs-n1o0-n6040392q01q@xxxxxx/ [2]: https://lore.kernel.org/git/xmqq5yjf4l60.fsf@gitster.g/
