"Johannes Schindelin via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > In that code, the return value of `GetFileAttributesW()` is interpreted > as an enum value, not as a bit field, so that a perfectly fine leading > directory can be misdetected as "not a directory". Nicely analyzed. So after all ENOTDIR was a buggy response and by fixing it we help all callers of lstat(), as pointed out in the earlier review. > * Thanks to Eric's excellent review, the reporter and I dug deeper and > figured out the real bug (and fix). Yeah, thanks all. Will queue.
