nonnull v.s. BUG() if !x (was: [PATCH v2] config.c: NULL check when reading protected config)

[Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx>]

On Tue, Jul 26 2022, Glen Choo via GitGitGadget wrote:

> From: Glen Choo <chooglen@xxxxxxxxxx>

> +	if (!filename)
> +		BUG("filename cannot be NULL");

Looks good, but as an aside I wonder if we wouldn't get better code
analysis with "nonnull" for this sort of thing, but we can leave this
for now:
https://gcc.gnu.org/onlinedocs/gcc-12.1.0/gcc/Common-Function-Attributes.html#Common-Function-Attributes