On Tue, Jul 26, 2022 at 7:26 PM Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> wrote: > But then we're losing the perf test coverage for the case where we don't > have the *.rev files. Isn't it better to run both with & without *.rev, > perhaps by splitting up the test file? We could make it a function in > perf/lib-bitmap.sh that we call both with & without the wanted *.rev > repack config. Ok. > I suspect that's also subtly broken, in that t/perf assumes that it can > re-use the repo for a given <rev>, but this is modifying that repo, so > if you run e.g. test Y after this Y, that Y will unexpectedly get a > repack'd repo ... Thanks Ævar! This is the problem that I informed Taylor off-list. Will update it. > But we could just start the test with a git clone . "$TEST_NAME" or > whatever, then repack that with whatever options we want... Thanks :)