Junio C Hamano <gitster@xxxxxxxxx> writes: > René Scharfe <l.s.r@xxxxxx> writes: > >> It starts by making llist_mergesort() leaner without reducing its >> performance: >> >> mergesort: unify ranks loops >> mergesort: tighten merge loop >> >> This matters for the next step, which creates the macro version of >> that function: >> >> mergesort: add macros for typed sort of linked lists >> >> The next two patches show the impact of using the macro on performance >> and object text size of the test helper: >> >> test-mergesort: use DEFINE_LIST_SORT_DEBUG >> test-mergesort: use DEFINE_LIST_SORT >> >> Then all llist_mergesort() callers get converted: >> >> blame: use DEFINE_LIST_SORT >> commit: use DEFINE_LIST_SORT >> fetch-pack: use DEFINE_LIST_SORT >> packfile: use DEFINE_LIST_SORT >> >> ... and the final patch removes the function which has become unused: >> >> mergesort: remove llist_mergesort() > > A nicely presented coherent story that results in an overall code > reduction. Thanks for a pleasant read. > > Will queue. No comments or objections from anybody? I am planning to merge the topic to 'next' and to 'master' soonish. Thanks.
