On Sat, 6 Oct 2007, Shawn Bohrer wrote:
>
> This replaces git-clean.sh with builtin-clean.c, and moves git-clean.sh to the
> examples.
This looks better, but I think you'd be even better off actually using the
"read_directory()" interface directly, instead of exec'ing off "git
ls-files" and parsing the line output.
I also would still worry a bit about 'chdir(x)' and 'chdir("..")', because
quite frankly, they are *not* mirrors of each other (think symlinks, but
also error behaviour due to directories that might be non-executable).
Now, admittedly, if a directory isn't executable, I can imagine other git
things having problems (anybody want to test?), but that whole pattern is
just very fragile and not very reliable.
Linus
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
