On Thu, Jul 21, 2022 at 12:07 PM Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> wrote: > On Wed, Jul 20 2022, Junio C Hamano wrote: > > "ZheNing Hu via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > > It's been quite many iterations, so I'll just comment on the range-diff. > > > >> -+ usage_msg_opt("--format cannot used with -s, -o, -k, -t" > >> ++ usage_msg_opt("--format cannot used with -s, -o, -k, -t, " > >> + "--resolve-undo, --deduplicate, --eol", > >> + ls_files_usage, builtin_ls_files_options); > > > > Looks good. > > Although a nit I didn't spot before: missing _() & this should be marked > for translation, surely... Probably also want: s/cannot used/cannot be used/