As a small follow-up to Junio's https://lore.kernel.org/git/xmqq7d471dns.fsf@gitster.g/; This is a small set of fixes to use the string_list functions rather than peeking into its guts during initalization. I've been running my local git version with these changes for almost a year, but for submision I wrote a coccinelle rule to cover most of it in 1/2, along with a tests using the new recently landed coccicheck test support. The 2/2 is then things I had to manually change still, which weren't covered by the conservative rule. Ævar Arnfjörð Bjarmason (2): string_list API users + cocci: use string_list_init_dup() string-list API users: manually use string_list_init_*() contrib/coccinelle/string_list.cocci | 8 ++++++++ contrib/coccinelle/tests/string_list.c | 7 +++++++ contrib/coccinelle/tests/string_list.res | 7 +++++++ notes-utils.c | 4 ++-- reflog-walk.c | 2 +- refs.c | 4 ++-- resolve-undo.c | 8 ++++---- revision.c | 4 ++-- 8 files changed, 33 insertions(+), 11 deletions(-) create mode 100644 contrib/coccinelle/string_list.cocci create mode 100644 contrib/coccinelle/tests/string_list.c create mode 100644 contrib/coccinelle/tests/string_list.res -- 2.37.1.1095.g64a1e8362fd
