Moritz Baumann (2): git-p4: fix typo in P4Submit.applyCommit() git-p4: fix error handling in P4Unshelve.renameBranch() git-p4.py | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) base-commit: bbea4dcf42b28eb7ce64a6306cdde875ae5d09ca Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1297%2Fmbs-c%2Ffix-undefined-variables-v2 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1297/mbs-c/fix-undefined-variables-v2 Pull-Request: https://github.com/git/git/pull/1297 Range-diff vs v1: 1: 1484eee8961 = 1: 1484eee8961 git-p4: fix typo in P4Submit.applyCommit() 2: 69c9fd5fbec ! 2: f7566dd5fc3 git-p4: fix error handling in P4Unshelve.renameBranch() @@ Metadata ## Commit message ## git-p4: fix error handling in P4Unshelve.renameBranch() - The error handling code referenced a variable that does not exist. - Also, the condition could never evaluate to True. + The error handling code path is meant to be triggered when the loop does + not exit early via "break". This fails, as the boolean variable "found", + which is used to track whether the loop was exited early, is initialized + incorrectly. + + It would be possible to fix this issue by correcting the initialization, + but Python supports a for:-else: control flow construct for this exact + use case (executing code if a loop does not exit early), so it is more + idiomatic to remove the tracking variable entirely. + + In addition, the error message no longer refers to a variable that does + not exist. Signed-off-by: Moritz Baumann <moritz.baumann@xxxxxxx> -- gitgitgadget
