Re: [PATCH] osx-keychain: fix compiler warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/19/2022 1:25 PM, Lessley Dennington via GitGitGadget wrote:
> From: Lessley Dennington <lessleydennington@xxxxxxxxx>
> 
> Update git-credential-osxkeychain.c to remove 'format string is not a string
> literal (potentially insecure)' compiler warning by treating the string as
> an argument.

>  	if (!argv[1])
> -		die(usage);
> +		die("%s", usage);

Thanks for preparing this for upstream. I reviewed this change as we
were doing related things in the microsoft/git fork. LGTM here, too.

Thanks,
-Stolee



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux