Re: [PATCH v4 12/12] sequencer: notify user of --update-refs activity

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 12, 2022 at 6:07 AM Derrick Stolee via GitGitGadget
<gitgitgadget@xxxxxxxxx> wrote:
>
> From: Derrick Stolee <derrickstolee@xxxxxxxxxx>
>
> When the user runs 'git rebase -i --update-refs', the end message still
> says only
>
>   Successfully rebased and updated <HEAD-ref>.
>
> Update the sequencer to collect the successful (and unsuccessful) ref
> updates due to the --update-refs option, so the end message now says
>
>   Successfully rebased and updated <HEAD-ref>.
>   Updated the following refs with --update-refs:
>         refs/heads/first
>         refs/heads/third

This seems good.

>   Failed to update the following refs with --update-refs:
>         refs/heads/second

This is good, but I think it could be improved.  Could we also include
the commit to which rebase would have updated the branch to?  That
would allow the user to manually update it if they want, or at least
see a range-diff between what we would have updated it to and what it
now has.  Without that information, the user might have difficulty
correcting that branch.


Anyway, I've only been able to find a few minor things in reviewing
this series.  It looks really good overall, and I'm sure lots of
people will be making use of it!



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux