On 22/07/13 02:54PM, Junio C Hamano wrote:
>
> OK, because "1" fails to execute, the expected output Dscho had
> (which is for the case without base) would become invalid when we
> use "true".
>
> Perhaps we should use "false" instead? Or do we need to test both?
>
I think testing both is not really needed as the unit test is just making sure
that filenames with spaces are processed correctly. Whatever comes before
(which changes depending on the value of "base_present") doesn't really matter
as long as there is something.
If we have to select one ("true" or "false") using "true" seems more practical,
as that way the BASE file is also included, and thus an extra argument is
tested.
