On Wed, Jul 13, 2022 at 3:25 AM Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> wrote: > > > On Tue, Jul 12 2022, Siddharth Asthana wrote: > > > -static int commit_rewrite_person(struct strbuf *buf, const char *what, struct string_list *mailmap) > > +/* > > + * Returns the difference between the new and old length of the ident line. > > + */ > > +static ssize_t rewrite_ident_line(const char* person, struct strbuf *buf, struct string_list *mailmap) > > All tests pass with this as size_t, instead of size_t. Let's use that > here instead? Do you mean you would like to use size_t instead of ssize_t for the type of the value returned by the function? I think it can return a negative value if the new length of the ident line is shorter than the old one though.
