On Tue, Jun 28, 2022 at 03:35:20PM -0700, Junio C Hamano wrote: > The fix looks quite straight-forward. It is somewhat disappointing > that it was caught after this loooong time, but as they say, better > late than never. I had the same thought, but I think that it points to something I've suspected privately for a while which is that we don't actually get many users to opt-in to features early when they are hidden behind a configuration. I had hoped that things like feature.experimental would cause more users to try features that weren't quite ready for prime-time more often, and that we'd get more and better feedback as a result. But I think that this proves that is generally not so. I think we should probably err on the side of enabling new features by default so long as there is sufficiently low risk, rather than hide them behind config. Or at least, not hide them behind a config variable for so long (though I am guilty of this myself with the pack.writeReverseIndex, which I have been meaning to flip the default on for a little while now). In either case... > Thanks for a quick report and a fix. Yes, indeed. This fix looks good to me. Thanks, Taylor
