On 6/28/2022 2:30 PM, Taylor Blau wrote: > The size and padding of `struct object_entry` is an important factor in > determining the memory usage of `pack-objects`. For this reason, > 3b13a5f263 (pack-objects: reorder members to shrink struct object_entry, > 2018-04-14) added a comment containing some information from pahole > indicating the size and padding of that struct. > > Unfortunately, this comment hasn't been updated since 9ac3f0e5b3 > (pack-objects: fix performance issues on packing large deltas, > 2018-07-22), despite the size of this struct changing many times since > that commit. ... > For that reason, eliminate the confusion by removing the comment > altogether. > - > - /* > - * pahole results on 64-bit linux (gcc and clang) > - * > - * size: 80, bit_padding: 9 bits > - * > - * and on 32-bit (gcc) > - * > - * size: 76, bit_padding: 9 bits > - */ > }; I will shed no tears over this being gone. Thanks! -Stolee
