Re: [PATCH v4 00/12] submodule: make "git submodule--helper" behave like "git submodule"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes:

> Changes since v3:
>
>  * Leave the --super-prefix changes aside for now. As discussed in the
>    v3 follow-up, now we're only removing the unused $prefix variable.
>
>    Since the v2 was submitted Glen's submitted a series of his own. I
>    think any non-trivial updates to --super-prefix are better done
>    there, as noted in:
>    https://lore.kernel.org/git/220628.86wnd1f9t1.gmgdl@xxxxxxxxxxxxxxxxxxx/
>
>    The overall diffstat is much smaller as a result, and I think this
>    series should be ready for "next" now, as the remaining changes are
>    well-revieweda at this point, with no outstanding issues.

Agreed. Since we no longer touch "--super-prefix", I think there aren't
any remaining concerns.

In v3, I was slightly concerned that we didn't fully understand the
rationale behind "--super-prefix" before changing it, but I still gave
that version my Reviewed-by because I'm convinced that the
"--super-prefix" check isn't doing anything useful (and can be
annoyingly overzealous).




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux