On Fri, Oct 05, 2007 at 09:43:55AM +1300, Martin Langhoff wrote: > On 10/5/07, Frank Lichtenheld <frank@xxxxxxxxxxxxxx> wrote: > > cvsserver returns a list of existing modules on command > > 'update' without a module specified (apparently this is > > used by some clients to get a list of available modules, > > the CVS cli client doesn't support it). > > > > Fix this code to work correctly in presence of packed refs. > > (Use git-branch instead of reading refs/heads/) > > ACK - good stuff - thanks! > > There is one minor issue around this I suspect - refs with slashes in > them. Without this patch, only refs that literally sit in refs/heads > will be returned. With git branches, you could see oldbranches/foo > being returned to the client. > > IIRC - the behaviour cvsserver supports here is completely > unspecified, and clients will probably error out in weird and wacky > ways. I'd perhaps filter out any headref with a slash. cvsserver also horribly breaks for module names with slashs in them. Something that might be good to be fixed, too. Gruesse, -- Frank Lichtenheld <frank@xxxxxxxxxxxxxx> www: http://www.djpig.de/ - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
