On 6/27/2022 2:06 PM, Abhradeep Chakraborty wrote: > Derrick Stolee <derrickstolee@xxxxxxxxxx> wrote: >> nit: This alignment should use four spaces at the end so the second phrase >> matches the start of the previous phrase. Like this: >> >> if (flags & BITMAP_OPT_LOOKUP_TABLE && >> git_env_bool("GIT_TEST_READ_COMMIT_TABLE", 1)) { >> >> Perhaps it looked right in your editor because it renders tabs as 4 spaces >> instead of 8 spaces. > > I don't know why but my editor sometimes do some weird things for alignments. > I generally use VS Code. But for alignment related problems, sometimes I have > to use vi editor. I also use VS Code, and I noticed a few spacing issues recently, especially in .txt files. I submitted a patch [1] to improve the contrib/vscode/init.sh script, which adds some helpful config settings to your Git workspace. Please take a look and see how it works for you. Thanks, -Stolee [1] https://lore.kernel.org/git/pull.1271.git.1656354587496.gitgitgadget@xxxxxxxxx