Re: [PATCH v2 3/6] pack-bitmap-write: learn pack.writeBitmapLookupTable and add tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 27, 2022 at 11:12:30PM +0530, Abhradeep Chakraborty wrote:
> Derrick Stolee <derrickstolee@xxxxxxxxxx> wrote:
>
> > I wonder if it makes sense to have it default to 'false' for now, but to
> > change that default after the feature has been shipped and running in
> > production for a while.
>
> I do not have any opinion. If most reviewers agree on it, I will surely
> Set it to false.

I think it's definitely a safe approach. I don't have a huge concern
about enabling it earlier, but I don't think we're in a huge rush to add
a new feature here, either.

So I'd be fine to ship this with the default being disabled (IOW, *not*
writing the lookup table). That should give us a window where we can
shake out whatever bugs there are, as is often the case when working
with the bitmap code ;).

Thanks,
Taylor



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux