ZheNing Hu <adlternative@xxxxxxxxx> writes: > Junio C Hamano <gitster@xxxxxxxxx> 于2022年6月27日周一 16:22写道： >> >> ZheNing Hu <adlternative@xxxxxxxxx> writes: >> >> >> >> + else if (skip_prefix(start, "(path)", &p)) >> >> >> + write_name_to_buf(sb, data->pathname); >> >> >> >> These are just "values". >> >> ... >> >> >> + else if (skip_prefix(start, "(size)", &p)) >> >> >> + strbuf_addf(sb, "size: %u", sd->sd_size); >> >> >> + else if (skip_prefix(start, "(flags)", &p)) >> >> >> + strbuf_addf(sb, "flags: %x", data->ce->ce_flags); >> >> >> >> These are not. >> >> >> > ... If someone else >> > need them for some reason, we can add them back. >> >> If someone else needs to see "size:" printed in front of the value >> of sd_size member, we DO NOT HAVE TO DO ANYTHING! That someone else >> can write "--format=size: %(size)" to do so themselves. > > Oh, sorry, I mean if someone need some atoms from %(size) to %(flags), we can > add them back. Ah, I see. I am not sure about the %(flags) to help the debugging mode, but giving a single bit "is it dirty?" would be more useful than giving the cached stat info, I would think. Thanks.
