On 6/24/2022 4:04 AM, Shaoxuan Yuan wrote: > > On 6/23/2022 11:08 PM, Derrick Stolee wrote: >> On 6/23/2022 7:41 AM, Shaoxuan Yuan wrote: >>> Originally, "git mv" a sparse file from out-of-cone to >>> in-cone does not update the moved file's sparsity (remove its >>> SKIP_WORKTREE bit). And the corresponding cache entry is, unexpectedly, >>> not checked out in the working tree. >>> >>> Update the behavior so that: >>> 1. Moving from out-of-cone to in-cone removes the SKIP_WORKTREE bit from >>> corresponding cache entry. >>> 2. The moved cache entry is checked out in the working tree to reflect >>> the updated sparsity. >> >> Since this is a behavior change, can we test it? It would be good >> to verify that the new path exists in the worktree after 'git mv' >> succeeds. > > I don't think we can effectively test this based on the change per se. > This change is preparing a correct behavior for the next few > commits, so I'll say it's tested along with the next few commits > (i.e. move "sparse" file/directory ones)? Ah, right. There are other reasons why moving from out-of-cone to in-cone is blocked at this point in time. Thanks, -Stolee
