Junio C Hamano <gitster@xxxxxxxxx> writes: > Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > >> test_expect_success 'override global and system config' ' >> - test_when_finished rm -f "$HOME"/.config/git && >> + test_when_finished "rm -rf \"$HOME\"/.config/git" && > > As this string is evaled, isn't it safer to defer dereferencing the > environment variable at the runtime by quoting the dollar-sign, too? > > I.e. > > test_when_finished rm -rf \"\$HOME\"/.config/git && > > or something? It probably would matter if $HOME had a double-quote in it, I think
