Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes:
> Fix two inclusions added in d42bab442d7 (core.fsyncmethod: tests for
> batch mode, 2022-04-04) that needed to be quoted, and the same sort of
> issue in a242c150ebb (vimdiff: integrate layout tests in the unit
> tests framework ('t' folder), 2022-03-30). Both were first released
> with v2.37.0-rc0.
Describe what symptom you may see if it is left unfixed. IOW, if we
consider that having a whitespace in the path to the build directory
is just as crazy as having a single-quote, it would make this patch
unnecessary, Make it easier for readers to decide, by saying
something like
As TEST_DIRECTORY is (typically) path to t/ in the extracted
source tree, it can have funny characters like $IFS whitespace
in it.
at least.
Thanks.
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx>
> ---
> t/t3700-add.sh | 2 +-
> t/t3903-stash.sh | 2 +-
> t/t7609-mergetool--lib.sh | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/t/t3700-add.sh b/t/t3700-add.sh
> index 8979c8a5f03..8689b48589c 100755
> --- a/t/t3700-add.sh
> +++ b/t/t3700-add.sh
> @@ -8,7 +8,7 @@ test_description='Test of git add, including the -- option.'
> TEST_PASSES_SANITIZE_LEAK=true
> . ./test-lib.sh
>
> -. $TEST_DIRECTORY/lib-unique-files.sh
> +. "$TEST_DIRECTORY"/lib-unique-files.sh
>
> # Test the file mode "$1" of the file "$2" in the index.
> test_mode_in_index () {
> diff --git a/t/t3903-stash.sh b/t/t3903-stash.sh
> index 20e94881964..2a4c3fd61c0 100755
> --- a/t/t3903-stash.sh
> +++ b/t/t3903-stash.sh
> @@ -9,7 +9,7 @@ GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
> export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
>
> . ./test-lib.sh
> -. $TEST_DIRECTORY/lib-unique-files.sh
> +. "$TEST_DIRECTORY"/lib-unique-files.sh
>
> test_expect_success 'usage on cmd and subcommand invalid option' '
> test_expect_code 129 git stash --invalid-option 2>usage &&
> diff --git a/t/t7609-mergetool--lib.sh b/t/t7609-mergetool--lib.sh
> index d848fe6442b..330d6d603d7 100755
> --- a/t/t7609-mergetool--lib.sh
> +++ b/t/t7609-mergetool--lib.sh
> @@ -7,7 +7,7 @@ Testing basic merge tools options'
> . ./test-lib.sh
>
> test_expect_success 'mergetool --tool=vimdiff creates the expected layout' '
> - . $GIT_BUILD_DIR/mergetools/vimdiff &&
> + . "$GIT_BUILD_DIR"/mergetools/vimdiff &&
> run_unit_tests
> '
