Ævar Arnfjörð Bjarmason wrote: > > On Tue, Jun 14 2022, Todd Zullinger wrote: >> Nice catch. FWIW, I tested w/GIT_TEST_ADD_I_USE_BUILTIN=0 >> and without. > > My patch landed on "master" as 7ccbea564e8 (add -i tests: mark "TODO" > depending on GIT_TEST_ADD_I_USE_BUILTIN, 2022-06-14) so this is water > under the bridge. > > But just to tie this loose knot I think something went wrong in your > testing. > > If I: > > git checkout v2.37.0-rc0 > # Apply your patch from <20220614185218.1091413-1-tmz@xxxxxxxxx> > > I'll consistently get a failure from: > > GIT_TEST_ADD_I_USE_BUILTIN=false ./t3701-add-interactive.sh > Sorry for being unclear. I meant that I tested your patch. The patch I sent didn't handle that case. :) -- Todd
