On Sat, May 28, 2022 at 04:11:13PM -0700, Junio C Hamano wrote: > From: Johannes Schindelin <johannes.schindelin@xxxxxx> > > By allowing the path to be enclosed in double-quotes, we can avoid > the limitation that paths cannot contain colons. > > Signed-off-by: Johannes Schindelin <johannes.schindelin@xxxxxx> > Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx> > --- > * Tightened shell variable quoting > > <snip> > > diff --git a/t/t5003-archive-zip.sh b/t/t5003-archive-zip.sh > index d6027189e2..3992d08158 100755 > --- a/t/t5003-archive-zip.sh > +++ b/t/t5003-archive-zip.sh > @@ -207,13 +207,21 @@ check_zip with_untracked > check_added with_untracked untracked untracked > > test_expect_success UNZIP 'git archive --format=zip --add-virtual-file' ' > + if test_have_prereq FUNNYNAMES > + then > + PATHNAME="pathname with : colon" > + else > + PATHNAME="pathname without colon" > + fi && > git archive --format=zip >with_file_with_content.zip \ > + --add-virtual-file=\""$PATHNAME"\": \ > --add-virtual-file=hello:world $EMPTY_TREE && > test_when_finished "rm -rf tmp-unpack" && > mkdir tmp-unpack && ( > cd tmp-unpack && > "$GIT_UNZIP" ../with_file_with_content.zip && > test_path_is_file hello && > + test_path_is_file "$PATHNAME" && > test world = $(cat hello) > ) > ' This test is currently failing on Cygwin: it looks like it's exposing a bug in Cygwin that means files with colons in their name aren't correctly extracted from zip archives. I'm going to report that to the Cygwin mailing list, but I wanted to note it for the record here, too. Adam
