Hi Abhradeep,
On Fri, Jun 10, 2022 at 10:54:40AM +0000, Abhradeep Chakraborty via GitGitGadget wrote:
> ++
> +In each bitmap, the `n`th bit is set to true if the `n`th object
> +in the packfile or multi-pack index is of that type.
> +
> + The obvious consequence is that the OR of all 4 bitmaps will result
> + in a full set (all bits set), and the AND of all 4 bitmaps will
> + result in an empty bitmap (no bits set).
> +
> + * N entries with compressed bitmaps, one for each indexed commit
> ++
> +Where `N` is the total amount of entries in this bitmap index.
> +Each entry contains the following:
The new formatting looks terrific; it's much easier to read this in my
browser after generating the HTML version of these docs. Two questions:
- Are the hard-tabs added in this file required for ASCIIDoc to treat it
correctly? They are a slight impediment to reading the source in my
editor, but it's not a huge deal. It would just be nice if we could
replace "\t" characters with two or four spaces or something.
- The above hunk is the only one which rendered slightly oddly to me; it
looks like the paragraph beginning with "The obvious consequence ..."
is surrounded by a <pre> element, when it should be a continuation of
the above paragraph ("In each bitmap ...").
Otherwise, this series is looking great. Let me know what you think!
Thanks,
Taylor
