On Tue, Jun 14, 2022 at 01:27:18PM -0400, Derrick Stolee wrote: > > Did you have any other sort of performance test in mind? The remotes we > > typically deal with are geographically far away and deal with a high volume > > of traffic so we're keen to move behaviour to the client where it makes sense > > to do so. > > I guess I wonder how large your promisor pack-files are in this test, > since your implementation depends on for_each_packed_object(), which > should be really inefficient if you're actually dealing with a large > partial clone. I had the same thought. Storing data available in the promisor packs into an oid_map is going to be expensive if there are many such objects. Is there a reason that we can't introduce a variant of find_kept_pack_entry() that deals only with .promisor packs and look these things up as-needed? Thanks, Taylor
