Re: Git Test Coverage Report for v2.37.0-rc0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/14/2022 4:20 PM, Derrick Stolee wrote:
> On 6/14/2022 4:18 PM, Derrick Stolee wrote:
>> Derrick Stolee	b56166ca multi-pack-index: use --object-dir real path
>> builtin/multi-pack-index.c
>> b56166ca 61) opts.object_dir = xstrdup(get_object_directory());
> 
> This is demonstrating that opts.object_dir is never populated before
> we parse the options. We must be handling a NULL object_dir properly
> somewhere else. I'll work on a patch to fix this.

I was looking at the wrong line. This line is testing the --no-object-dir
option, which is fine to leave untested, probably.

Thanks,
-Stolee



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux