On Thu, 2007-09-27 at 02:05 -0700, Junio C Hamano wrote: ... > I think the right organization for the "builtin-commit" series > should be: > > * merge strbuf topic in kh/commit topic, in order to get the > stripspace updates and strbuf_read_file(); > > * add--interactive entry point change (respin the one from the > old series); > > * rename update() to add_files_to_cache() and export (respin > this [2/4] with a better commit message); > > * create a separate rerere() function and export (respin part > of old series, with proper refactoring); > > I am not happy with builtin-foo.c calling into something from > builtin-bar.c, though. We probably would want to move > rerere() and add_files_to_cache() somewhere else. > > * move launch_editor() and stripspace() to create editor.c (new > [4/4]); > > * add option parser in parse-options.[ch] (new [1/4]); > > * finally, create builtin-commit that uses the groundwork laid > out above (new [3/4]). > > I ended up doing the above up to the rerere() one myself, but > haven't done the rest. >From what I see in next today, it looks like we're just missing the parse-options patch and builtin-commit patches. I resent a better version of parse-options and a patch that ports builtin-add.c to the option parser. To use the option parser in more places, we'll probably have to extend it a bit, but the patch is a good start. Let's get that in shape and into next and then I'll send an updated builtin-commit patch. thanks, Kristian - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
