Neeraj Singh <nksingh85@xxxxxxxxx> writes: >> Still, we need to save the temporary file we're preparing >> somewhere. We'll do that in the top-level ".git/objects/" >> directory (or whatever "GIT_OBJECT_DIRECTORY" is set to). Once we've >> streamed it we'll know the OID, and will move it to its canonical >> path. >> > > I think this new logic doesn't play well with batched-fsync. Even > through we don't know the final OID, we should still call > prepare_loose_object_bulk_checkin to potentially create the bulk > checkin objdir. Good point. Careful sanity checks like this are very much appreciated. > Thanks for including me on the review! Yes, indeed. Thanks, both.
