Am 04.06.22 um 02:54 schrieb Ævar Arnfjörð Bjarmason: > > To your comment here & some others (e.g. FREE_AND_NULL()): I was really > trying to focus on narrowly addressing these -fanalyzer issues without > digressing into the larger topics "what is this code *really* doing, and > does it make sense?". It was pretty unavoidable in 13/15 though. > > Which isn't to say that I shouldn't fix some of it, e.g. your > s/return/BUG()/ suggestion, but I think it's best to view these patches > with an eye towards us already having these issues, and in most cases > making -fanalyzer happy is a small cost. > > And by doing so and getting a "clean build" we'll be able to turn it on > in CI, and thus notice when we run into new -fanalyzer issues. Future analyzer reports are likely of the same quality as the current ones. If the goal is to shush them then we should just not use the analyzer. If reports contain a helpful signal, e.g. pointing to a real bug or to overly complicated code, then we better address these issues. We can think about automating the analyzer once we have a certain number of commits with improvements that would not have been made without it. René
