The $subject is a proposed re-roll of SZEDER's https://lore.kernel.org/git/20220525205651.825669-1-szeder.dev@xxxxxxxxx; As noted downthread of that fix having the Makefile invoke "make -C gitweb" again would slow us down on NOOP runs by quite a bit. This series fixes the same regression with an amended 7/7 version of SZEDER's fix, but starts out by having the top-level Makefile include the gitweb/Makefile. This series is smaller than it looks, most of the commits preceding 5-6/7 are there to make that diff smaller and easier to read, by splitting up earlier changes into non-functional changes. For this re-roll the equivalent of the "git hyperfine" command I posted in [2] will return; Summary 'make NO_TCLTK=Y' in 'origin/master' ran 1.00 ± 0.11 times faster than 'make NO_TCLTK=Y' in 'HEAD~0' 2.64 ± 0.26 times faster than 'make NO_TCLTK=' in 'origin/master' 2.64 ± 0.24 times faster than 'make NO_TCLTK=' in 'HEAD~0' I.e. we are no slower or faster than before, but now "make && sudo make install-gitweb" will only copy already-generated files from the "make" command in the "sudo" step, as intended. 1. https://lore.kernel.org/git/20220525205651.825669-1-szeder.dev@xxxxxxxxx 2. https://lore.kernel.org/git/220526.86k0a96sv2.gmgdl@xxxxxxxxxxxxxxxxxxx/ SZEDER Gábor (1): Makefile: build 'gitweb' in the default target Ævar Arnfjörð Bjarmason (6): gitweb/Makefile: define all .PHONY prerequisites inline gitweb/Makefile: add a $(GITWEB_ALL) variable gitweb/Makefile: clear up and de-duplicate the gitweb.{css,js} vars gitweb/Makefile: prepare to merge into top-level Makefile gitweb: remove "test" and "test-installed" targets gitweb/Makefile: include in top-level Makefile Makefile | 24 ++++---- gitweb/Makefile | 143 +++++++++++++++--------------------------------- t/Makefile | 4 -- 3 files changed, 59 insertions(+), 112 deletions(-) Range-diff against v1: 1: 1bbffa8a2b6 < -: ----------- Makefile: build 'gitweb' in the default target -: ----------- > 1: 14361617ca6 gitweb/Makefile: define all .PHONY prerequisites inline -: ----------- > 2: 7d920a13518 gitweb/Makefile: add a $(GITWEB_ALL) variable -: ----------- > 3: e14a5b73061 gitweb/Makefile: clear up and de-duplicate the gitweb.{css,js} vars -: ----------- > 4: 02e26ca8ce2 gitweb/Makefile: prepare to merge into top-level Makefile -: ----------- > 5: caf376f3dd9 gitweb: remove "test" and "test-installed" targets -: ----------- > 6: b423cd58f6b gitweb/Makefile: include in top-level Makefile -: ----------- > 7: 69428540886 Makefile: build 'gitweb' in the default target -- 2.36.1.1103.g036c05811b0
