On 28 May 2022, at 13:24, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > >> But the commit message & documentation here really should be updated to >> reflect that this is currently superfluous to inspecting argv in the >> hook process, and that we're providing this anyway for XYZ reason. > > Or this probably is better added as part of the series that actually > adds the mechanism to trigger hooks defined in the configuration > file. I don't mind including this as part of Ævar's config hook series. On the other hand this patch could allow the config hooks series to be smaller and more easily reviewed. I'm okay either way--maybe Ævar can speak to what his preference is. > > Then "we do not need it now, but we will in the future because we > will do XYZ" does not have to be said, which is a huge plus. > > Thanks. thanks John
