On 2022.05.20 14:49, Frantisek Hrbata wrote: > Fix memory leaks in transport_push(), where remote_refs and local_refs > are never freed. While at it, remove the unnecessary indenting and make > the code hopefully more readable. > > Changes since v2: > > * "transport: remove unnecessary indenting in transport_push()" > s/push_refs/transport_push/ in commit message as noticed > by Ævar Arnfjörð Bjarmason > > * "transport: unify return values and exit point from transport_push()" > Added as suggested by Ævar Arnfjörð Bjarmason. It allows the following > memory leak fix to be a very simple patch. > > * "transport: free local and remote refs in transport_push()" > Just free remote_refs and local_refs. The other changes were > included in the previous patch. > > Changes since v1: > > * Slit into series of two patches. The first one just changes > indenting in transport_push(). Second one adds the fix for > the local_refs and remote_refs memory leaks. > > * The resulting trees are the same, there is no code change. > > Frantisek Hrbata (3): > transport: remove unnecessary indenting in transport_push() > transport: unify return values and exit point from transport_push() > transport: free local and remote refs in transport_push() > > transport.c | 260 +++++++++++++++++++++++++++------------------------- > 1 file changed, 133 insertions(+), 127 deletions(-) Sorry for the late review. This all looks good to me, thanks for the fix! Reviewed-by: Josh Steadmon <steadmon@xxxxxxxxxx>
