Junio C Hamano <gitster@xxxxxxxxx> writes: > Instead of letting "update-index --refresh" report paths needing > updates and merges, use git-status to give more useful output. > > Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx> > --- > > * I won't be a good judge of the updated behaviour, as I never > start rebase in an unclear tree. Running git-status in a > large tree may be too expensive to be worth changing the > output. I see your patch as an improvement too. status is a bit expansive, but you hit this portion of code only when trying "rebase" by mistake, so it's acceptable to let git take a bit of time to explain your mistake. That said, I think it's still worth making the messages of "update-index" a little more verbose and consistant with "status" (my previous patch), since I think there are other occurences of user-visible output of update-index in porcelain git. Ideally, update-index would be a C function returning a struct containing all the information about the status, with a function is_clean(...) and another print_as_status(...), to allow the same functionality with better performances, but I won't have time to do this. -- Matthieu - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
