On Tue, May 24, 2022 at 02:44:37PM -0700, Junio C Hamano wrote: > Taylor Blau <me@xxxxxxxxxxxx> writes: > > > Before calling `for_each_object_in_pack()`, the caller > > `read_packs_list_from_stdin()` loops through each of the `include_packs` > > and checks that its `->util` pointer (which is used to store the `struct > > packed_git *` itself) is non-NULL. > > > > This check is redundant, because `read_packs_list_from_stdin()` already > > checks that the included packs are non-NULL earlier on in the same > > function (and it does not add any new entries in between). > > > > Remove this check, since it is not doing anything in the meantime. > > Will it start doing something soon in a later step? > > Oh, did you mean that after the earlier for_each_string_list_item() > iteration over include_packs that died on an item with a NULL .util > member, the code did not do anything to cause this second iteration > over the same list to suddenly start seeing an item with NULL .util? > > I am puzzled by the mention of "in the meantime". The latter, sorry for the confusion. > The patch itself looks correct, of course. Thanks. Taylor
