On Tue, May 24 2022, Junio C Hamano wrote: > Carl Smedstad <carl.smedstad@xxxxxxxxxxxxxx> writes: > >>> Not commenting on the patch itself, but ... >>> >>> > find . | >>> > git check-ignore --verbose --non-matching | >>> > grep $'^::\t' | >>> > sed -e 's/.*\t//' >>> >>> ... feeding grep output to sed caught my eyes. Isn't that equivalent to >>> >>> git ... | >>> sed -n '/^::\t/s/.*\t//p' >> >> That is indeed equivalent. TIL about regular-expression addresses in >> sed, thanks! > > I however suspect that these "\t"'s should be spelled out as an > actual TAB in the final production version for portability. Make that a "for sure", it's a commonly unsupported feature of some sed's, it's actually more common that not that it isn't supported. See $HT in t4213-log-tabexpand.sh.