Hi Junio,
On Mon, 23 May 2022, Junio C Hamano wrote:
> "Jeff Hostetler via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes:
>
> > +int cmd__hexdump(int argc, const char **argv)
> > +{
> > + char buf[1024];
> > + ssize_t i, len;
> > +
> > + for (;;) {
> > + len = xread(0, buf, sizeof(buf));
> > + if (len < 0)
> > + die_errno("failure reading stdin");
> > + if (!len)
> > + break;
> > +
> > + for (i = 0; i < len; i++)
> > + printf("%02x ", (unsigned char)buf[i]);
> > + }
> > +
> > + return 0;
> > +}
>
> It is meant to be consumed by machine, so I do not think we would
> mind too much about a single long line, but given that consumers
> include "grep", it would probably be better to avoid emitting an
> incomplete line, especially since addition of this tool is all about
> portability across platforms.
Do you know of any `grep` implementation that has problems with text
missing the usual trailing newlines?
Ciao,
Dscho
