On Mon, May 23 2022, Jiang Xin wrote: > On Mon, May 23, 2022 at 3:27 PM Ævar Arnfjörð Bjarmason > <avarab@xxxxxxxxx> wrote: >> >> >> On Mon, May 23 2022, Jiang Xin wrote: >> >> > .PHONY: pot >> > pot: po/git.pot >> > @@ -3319,6 +3319,7 @@ dist-doc: git$X >> > >> > distclean: clean >> > $(RM) configure >> > + $(RM) po/git.pot >> >> I think I noted "why not add this to clean?" in an earlier round, but >> didn't think it through. >> >> On second thought we should do that, but the reason is that "distclean" >> should only clean things that you get if you do "make dist". >> >> I.e. we add "configure" to a generated tarball, but not po/git.pot, so >> this should just be under regular "clean", not "distclean". > > Will remove "po/git.pot" under regular "clean" rule in next reroll. I > copied it from your original patch without thinking carefully. Yes, sorry about that. Just to be clear I didn't think this was an issue you introduced. To be honest I thought it could be mine or yours, and didn't dig to look into the history :) I have no idea why I added it to distclean, and it doesn't make any sense to me now, but oh well, as long as we fix it ... :)
