On Tue, Oct 02, 2007 at 05:22:23PM -0700, Junio C Hamano wrote: > > strbuf_init(&url); > > strbuf_addf(&url, "%s/objects/pack/pack-%s.idx", repo->base, hex); > > Ugh, this typically calls snprintf() twice doesn't it? Yes, it probably does. However, I think it is considerably easier to read and more maintainable. Are you "ugh"ing because of the performance impact (which should be negligible unless this is in a tight loop) or because of the portability problems associated with va_copy? -Peff - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
