[PATCH 0/4] Another round of the --track patches

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2007-09-18 at 15:38 -0700, Junio C Hamano wrote:
> Federico Mena Quintero <federico@xxxxxxxxxx> writes:
> > -	retrieve data from the remote branch.  Set the
> > +	retrieve data from the remote branch, otherwise you'll have to
> > +	use "git pull <url>" explicitly.  Set the
> >  	branch.autosetupmerge configuration variable to true if you
> >  	want git-checkout and git-branch to always behave as if
> >  	'--track' were given.
> 
> Hmph.
> 
> I'd rather make them consistent by dropping the not-so-correct
> "otherwise" phrase from all three copies.  It is not "otherwise
> you'll have to", but "instead you can".

Sure, I've added better wording now.

> I am inclined to suggest rewording the message like this, and
> make this condition an error (i.e. "exit 1"):
[snip]

I like that message much better, and it's nice that it gives you the
snippet to put in your config file.  This is in patch 4/4.

Thanks for the review; I hope this can make it in now ;)

  Federico

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux