Carlo Arenas <carenas@xxxxxxxxx> writes: >> Hmph, it may not be needed, but it should still work, in which case >> it probably is still worth testing, even with the optional patch #4. > > Just because it works, it doesn't mean we have to test it. Yes. It all depends on the answer to this question: Is it reasonably expected that any half-way intelligent Git user would not be surprised to learn that "sudo sudo git status" would be a way to work on a repository that is owned by root as root? Given that "sudo git status" is a good way to work on a repository that is owned by you as root, perhaps the answer is yes, but I am not a representative sample ;-) If the answer is yes, then we would want to make sure it will continue to work by having a test to protect it from future breakage. If not, and "sudo sudo git" (or worse "sudo sudo sudo git") is something that would be imagined by the most wicked mind and no sane person would imagine it would be a way to achieve something useful, no, it does not have to be protected from any future breakage. So...
